fix: mcp-bridge flaky test #12863
Open
fix: mcp-bridge flaky test #12863
+57
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Member
|
@LiteSun still one test case failed, pls fix it |
Member
done. |
membphis
previously approved these changes
Jan 9, 2026
bzp2010
reviewed
Jan 9, 2026
Contributor
There was a problem hiding this comment.
You have already extracted and copied package-lock.json from the archive package. Does this still need to be committed separately?
Member
There was a problem hiding this comment.
You have already extracted and copied package-lock.json from the archive package. Does this still need to be committed separately?
Good catch. I didn’t notice before that there was already a lock file at the npm workspace level. It has been updated.
bzp2010
previously approved these changes
Jan 9, 2026
membphis
previously approved these changes
Jan 12, 2026
ci/prepare_filesystem_mcp.sh
Outdated
| ( | ||
| cd "${DEST_DIR}" | ||
| npm install | ||
| # Note: Although dlx specifies the package version, it does not use a lockfile, |
Member
There was a problem hiding this comment.
nice, it is really important and useful information
SkyeYoung
previously approved these changes
Jan 12, 2026
bzp2010
previously approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In previous tests, the MCP Server was started using the following command:
However, during repeated test runs, this approach was found to cause unstable sub-dependency resolution. Different runs could resolve different versions of transitive dependencies, leading to MCP Server startup failures or inconsistent behavior, which negatively impacted test reliability.
Changes
To ensure stability and reproducibility of the test environment, this PR updates the build process for
[email protected]as follows:pnpm dlxto dynamically fetch and execute the packagehttps://github.com/modelcontextprotocol/servers/archive/refs/tags/2025.7.1.tar.gz[email protected]MCP Server using the includedpackage-lock.jsonScope of Impact
[email protected])Checklist